fix: add URL signing methods to ObjectStoreProtocol and storage backends #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add teardown_function() to clear correlation IDs after tests to prevent
test pollution when running with pytest-xdist. The test_correlation_id_formats
test sets a long correlation ID ("a" * 1000) that was leaking into other
tests running in the same process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper URL signing support to storage backends with type-safe methods in the
ObjectStoreProtocol. Also includes logging improvements across the codebase and a new config normalization utility.The Problem
The
ObjectStoreProtocolwas missingsignandsign_asyncmethods even thoughObStoreBackendimplemented them. This caused type checking issues when using URL signing functionality (see #286).The Solution
sign_sync,sign_async, andsupports_signingproperty toObjectStoreProtocolObStoreBackendusing obstore's nativeobs.sign()with batch supportNotImplementedErrorimplementations in FSSpec and LocalStore backendsget_logger()helper with structured extra data instead of string interpolationKey Features
sign_sync/sign_asyncaccept single path or list of pathssupports_signingproperty for runtime capability checkingCloses #286